Add wasm32 support to the rust sdk (updated)#4089
Open
kistz wants to merge 20 commits intoclockworklabs:masterfrom
Open
Add wasm32 support to the rust sdk (updated)#4089kistz wants to merge 20 commits intoclockworklabs:masterfrom
wasm32 support to the rust sdk (updated)#4089kistz wants to merge 20 commits intoclockworklabs:masterfrom
Conversation
- `DbConnectionBuilder::build` becomes async without tokio's block_in_place. Still need to add `web` feature flag.
Renamed the `run_threaded` method on `wasm32` to better reflect its behavior of spawning a background task. The generated `DbConnection` methods `run_threaded`, `run_background`, and `advance_one_message_blocking` now include runtime panics with a clear error feedback when called on unsupported targets.
Trim down repetitive `cfg` clauses by extracting common lock patterns into `get_lock_[sync|async]`.
Moves the creation of DbContextImplInner and DbContextImpl into private helper functions (`build_db_ctx_inner` and `build_db_ctx`) to reduce duplication between the web and non-web implementations of `build_impl`.
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
Superscedes and is: #2704 so all credit goes to @thlsrms
This branch is updates to the latest master through cherry-picking leaving out the problematic switch to
anymap3thats currently holding back the pr.All commit authorships are kept since i only rebased it :>
Since @thlsrms seems to be unavailbale right now i'd say we push this to finish line @gefjon ?
Testing